Updated ITSTrackSimulation to run with O2DPG - #1115
Merged
Merged
Conversation
IsakovAD
commented
Mar 24, 2022
IsakovAD
commented
Collaborator
- MCKinematics via MCKinematicsReader (previously was done using the .root file provided by o2-MC simulation workflow)
- Improved aggregation of the averaged plots
- Removed not used parameters from the .json file
- Fixed titles of the histograms
- Added binominal errors for ratio of the histograms
- Added TH1 for pT distribution of primary generated/reconstructed particles
iravasen
reviewed
Mar 28, 2022
iravasen
marked this pull request as ready for review
March 28, 2022 17:28
Collaborator
|
@IsakovAD thanks a lot! I marked this PR as ready (was draft) and I have only the two comments above. |
Collaborator
|
if you want this PR to be in the next FLP Suite please merge it by tomorrow noon. |
iravasen
approved these changes
Mar 29, 2022
iravasen
enabled auto-merge (squash)
March 29, 2022 21:18
Collaborator
|
All suggestions done. Enabling auto-merge. Thanks a lot! |
nasirmehdimalik
pushed a commit
to nasirmehdimalik/QualityControl
that referenced
this pull request
Apr 18, 2022
* Updated ITSTrackSimulation to run with O2DPG * returned task parameters, added AngularDistribution of track histogram Co-authored-by: JianLIUhep <jian.liu@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.